Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Embeddable] Improve inheritance to support embeddable variables #140405

Closed
dokmic opened this issue Sep 9, 2022 · 3 comments
Closed

[Embeddable] Improve inheritance to support embeddable variables #140405

dokmic opened this issue Sep 9, 2022 · 3 comments
Labels
Feature:Embedding Embedding content via iFrame impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@dokmic
Copy link
Contributor

dokmic commented Sep 9, 2022

Background

In order to implement #134706, we would need to provide a way to override children’s inputs from a container.

Proposal

This can be done after we implement seamless React support and refactor state inheritance. The main requirement is to be able to define what parts of the state are inherited and overridden.
@dokmic dokmic added Feature:Embedding Embedding content via iFrame loe:medium Medium Level of Effort impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:AppServicesUx labels Sep 9, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServicesUx)

@dokmic dokmic mentioned this issue Sep 9, 2022
Closed
8 tasks
@petrklapka petrklapka added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas and removed Team:AppServicesUx labels Dec 12, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@ThomThomson
Copy link
Contributor

Closing this for the time being as we currently need to focus on embeddable container state management before we do any of these longer-term

@ThomThomson ThomThomson closed this as not planned Won't fix, can't repro, duplicate, stale Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature:Embedding Embedding content via iFrame impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ThomThomson @dokmic @elasticmachine @petrklapka