Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Files] Design feedback for the upload component #143724

Closed
jloleysens opened this issue Oct 20, 2022 · 3 comments · Fixed by #143744
Closed

[Files] Design feedback for the upload component #143724

jloleysens opened this issue Oct 20, 2022 · 3 comments · Fixed by #143744

Comments

@jloleysens
Copy link
Contributor

jloleysens commented Oct 20, 2022

@mdefazio 's feedback:

Uploading a file

Should the text inside the file upload simply say 'Select or drop a file' to be more concise? Removes the extra conjunction.

image

When uploading the file, let's use the loading button , and then change it to a success button with the check icon. The label could then say 'Upload complete'. We would not need to use the pink line loading indicator in this case then. I would imagine this would be the same behavior for the Basic and Allow repeated uploads options.
The Long error scenario should also use the default button, instead of an empty button. Though in this case, we could use the danger styling. The error messages seem fine though.

If I abort the upload, should that message not appear somewhere? Also switching this to a default button rather than empty like the other scenarios can help keep this upload button the main focus. Perhaps reusing the Max size option here, but simply changing the text to 'File upload cancelled'

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServicesUx)

@jloleysens
Copy link
Contributor Author

Original comment: #143111 (review)

@jloleysens
Copy link
Contributor Author

Should the text inside the file upload simply say 'Select or drop a file' to be more concise? Removes the extra conjunction.

This is the default text in the EUI upload component. For this component we do allow users to override this default per their use case 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants