Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit the alerts-as-data fields available for alert summaries #143741

Closed
Tracked by #143200
mikecote opened this issue Oct 20, 2022 · 5 comments
Closed
Tracked by #143200

Limit the alerts-as-data fields available for alert summaries #143741

mikecote opened this issue Oct 20, 2022 · 5 comments
Labels
blocked Feature:Alerting/RulesFramework Issues related to the Alerting Rules Framework Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)

Comments

@mikecote
Copy link
Contributor

mikecote commented Oct 20, 2022

Meta: #143200

We should filter out the kibana.* fields from being exposed to rule actions. However, by doing so, I don't think ECS will contain sufficient information for users to iterate through the alerts and provide a brief overview of each. We should create and approve an explicit list of kibana.* fields that we will allow and filter the rest of the kibana.* fields out.

The filtering should happen within the rule registry in the work done by #143374.

Conversation thread leading to this issue: #143376 (comment).

@mikecote mikecote added blocked Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:Alerting/RulesFramework Issues related to the Alerting Rules Framework labels Oct 20, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@mikecote mikecote moved this from Awaiting Triage to Todo in AppEx: ResponseOps - Execution & Connectors Oct 20, 2022
@mikecote mikecote moved this from Todo to Blocked / On hold in AppEx: ResponseOps - Execution & Connectors Oct 20, 2022
@mikecote
Copy link
Contributor Author

mikecote commented Oct 20, 2022

Note that we don't need kibana.alert.rule.* because rule is passed in directly as a context variable (ex: {{rule.id}}) so it doesn't need to be accessed via {{alerts.new[x].kibana.alert.rule.id}}. However, we could make sure the rule object contains what is necessary.

@mikecote mikecote moved this from Blocked / On hold to Todo in AppEx: ResponseOps - Execution & Connectors Nov 7, 2022
@mikecote mikecote removed the blocked label Nov 7, 2022
@mikecote
Copy link
Contributor Author

To facilitate knowing what fields, let's use the list of proposed standardized fields (https://docs.google.com/document/d/1qNagq5Je_77WM91MBweZfGKbM93BIdgyOGChlCtPzYc/edit). Maybe we leave kibana.alert.rule.* in so the structure matches alerts-as-data as much as possible..

@mikecote mikecote moved this from Todo to Blocked / On hold in AppEx: ResponseOps - Execution & Connectors Nov 10, 2022
@mikecote
Copy link
Contributor Author

The filtering should happen within the rule registry in the work done by #143374.

Re-adding blocked label. On second thought, I don't think we should do this at the rule registry level. We'll have to keep existing security solution rules backwards compatible by injecting a mustache variable context.alerts which should have access to all the fields. We can implement this filter within the framework once we make use of the getSummarizedAlerts API.

@mikecote
Copy link
Contributor Author

Closing as no longer needed.

Repository owner moved this from Blocked / On hold to Done in AppEx: ResponseOps - Execution & Connectors Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Feature:Alerting/RulesFramework Issues related to the Alerting Rules Framework Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
None yet
Development

No branches or pull requests

2 participants