Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Actions] relatedSavedObjects should allow multiple namespaces #144112

Closed
ymao1 opened this issue Oct 27, 2022 · 2 comments
Closed

[Actions] relatedSavedObjects should allow multiple namespaces #144112

ymao1 opened this issue Oct 27, 2022 · 2 comments
Assignees
Labels
Feature:Actions/ConnectorTypes Issues related to specific Connector Types on the Actions Framework Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)

Comments

@ymao1
Copy link
Contributor

ymao1 commented Oct 27, 2022

    🤔 we have a discrepancy here. The actions plugin API [only contemplates a single `namespace: string`](https://github.com/elastic/kibana/blob/main/x-pack/plugins/actions/server/lib/related_saved_objects.ts#L15) for each of the "relatedSavedObjects". Isn't there a way that you can choose the most relevant one? 😝 

A possible "solution" would be for the notifications plugin to split the related SO into multiple related SOs if they belong to multiple spaces.
On the other hand, we could update the schema of RelatedSavedObjects, but I'm afraid this would have a bunch of side effects that we'd have to cope with.

Originally posted by @gsoldevila in #143303 (comment)

When we created the idea of relatedSavedObjects to be passed to the action executor and persisted to the event log, saved objects could only exist in a single space so we had a namespace field. Now we have a need to persist saved objects that can exist in multiple spaces so we need a way to store multiple namespaces.

@botelastic botelastic bot added the needs-team Issues missing a team label label Oct 27, 2022
@ymao1 ymao1 added Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:Actions/ConnectorTypes Issues related to specific Connector Types on the Actions Framework labels Oct 27, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Oct 27, 2022
@ymao1 ymao1 self-assigned this Oct 27, 2022
@ymao1
Copy link
Contributor Author

ymao1 commented Nov 1, 2022

Closing as not needed.

@ymao1 ymao1 closed this as completed Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Actions/ConnectorTypes Issues related to specific Connector Types on the Actions Framework Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants