Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't store unmodified state from a saved object in the url #14455

Closed
stacey-gammon opened this issue Oct 13, 2017 · 3 comments
Closed

Don't store unmodified state from a saved object in the url #14455

stacey-gammon opened this issue Oct 13, 2017 · 3 comments
Labels
discuss release_note:enhancement Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@stacey-gammon
Copy link
Contributor

I was going over this issue #10165, and got to thinking about how we store all this state in the url which creates it's own set of problems.

Currently, as soon as an object is opened, like a dashboard, the url is filled with the saved AppState. If that dashboard is modified, refreshing the page won't pick up those modifications because the url state overrides the saved object state. If we only stored modified state in the url then changes from the saved object would be picked up automatically.

This would result in shorter urls in many situations, like if a user is only interested in viewing a dashboard, not editing it. It would also mean that saved changes would automatically refresh, which is another win.

@stacey-gammon
Copy link
Contributor Author

related: #10727

@timroes
Copy link
Contributor

timroes commented Sep 14, 2018

On the downside URLs are not directly shareable anymore and undo wouldn't work as easy in the browser anymore. I labelled this with discuss and the new intent-discuss so we can put this into a further meeting discussing if we want to continue with this or not.

@timroes
Copy link
Contributor

timroes commented Apr 30, 2019

I am closing this in favor of #35812 for an aligned discussion around state handling in the URL.

@timroes timroes closed this as completed Apr 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss release_note:enhancement Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

2 participants