Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Embeddable] Seamless React by Default #147894

Closed
ThomThomson opened this issue Dec 20, 2022 · 2 comments
Closed

[Embeddable] Seamless React by Default #147894

ThomThomson opened this issue Dec 20, 2022 · 2 comments
Labels
Feature:Embeddables Relating to the Embeddable system impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:large Large Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@ThomThomson
Copy link
Contributor

ThomThomson commented Dec 20, 2022 •
edited
Loading

Describe the feature: #143131 added a seamless react integration to Embeddables. This integration is so far unused outside of examples. If adopted more widely, this would lead to performance, and DX improvements, as using an embeddable would no longer break the react tree. Things like React Context could be maintained through multiple levels of Embeddables.

To accomplish this, we should attempt to change all embeddable implementations to use the seamless react integration, remove the old integration, and fix any regressions or bugs that crop up.
@ThomThomson ThomThomson added Feature:Embedding Embedding content via iFrame Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas loe:large Large Level of Effort impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. labels Dec 20, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@ThomThomson ThomThomson added Feature:Embeddables Relating to the Embeddable system and removed Feature:Embedding Embedding content via iFrame labels Jun 14, 2023
@ThomThomson
Copy link
Contributor Author

Closing this in favour of the Embeddables Rebuild initiative.

@ThomThomson ThomThomson closed this as not planned Won't fix, can't repro, duplicate, stale Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature:Embeddables Relating to the Embeddable system impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:large Large Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ThomThomson @elasticmachine