Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Cannot use apm integration in elastic-package #147907

Closed
ruflin opened this issue Dec 21, 2022 · 5 comments
Closed

[Fleet] Cannot use apm integration in elastic-package #147907

ruflin opened this issue Dec 21, 2022 · 5 comments
Labels
Team:Fleet Team label for Observability Data Collection Fleet team

Comments

@ruflin
Copy link
Contributor

ruflin commented Dec 21, 2022

I've been playing around with elastic-package and the apm package. Since version 8.5. there is a problem when I want to use APM. In 8.4 it all still works. This is independent of if I use a snapshot or a released build. My assumption is that it has to do with the bundled package change: #137759

First about the error I see and how to reproduce it:

  • Spin up elastic-package stack up --version=8.5.3 (or 8.7.0-SNAPSHOT)
  • Add the APM integration to one of the elastic agents.

After a long wait, the following error message is shown:

Screenshot 2022-12-20 at 15 10 43

For some reasons, it doesn't seem to take the bundled package but instead tries to get it from the package registry. This is the reason I file this issue here as I assume this is a Fleet issue.

The latest package that exists in the registry is 8.4.2: https://epr.elastic.co/search?package=apm I tried to get out of #137759 on where we landed around still shipping the bundled packages to the registry but it is not clear to me. On my end I still think we should ship a bundled packages to the registry. Especially now with v2 and the prerelease flag, we can continously add the packages. It shouldn't be the solution to this problem here as it would just hide it.

@ruflin ruflin added the Team:Fleet Team label for Observability Data Collection Fleet team label Dec 21, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@simitt
Copy link
Contributor

simitt commented Dec 21, 2022

pinging @elastic/apm-server for visibility

@kpollich
Copy link
Member

This is a duplicate of #136617. The root cause is that "GET integration" API always tries to use the registry even if the package is bundled.

On my end I still think we should ship a bundled packages to the registry. Especially now with v2 and the prerelease flag, we can continously add the packages. It shouldn't be the solution to this problem here as it would just hide it.

I also agree with this. Shipping many prerelease version of the APM integration to the registry should no longer be a concern in v2. My memory is a little fuzzy on the specifics around the long thread of comments on #137759 (I think there were numerous offline conversations as well), but @axw can probably help clarify some of the motivations for no longer publishing APM to package storage at all.

@ruflin
Copy link
Contributor Author

ruflin commented Dec 29, 2022

Closing this as a duplicate. I'm a bit concerned that #136617 has been open for quite a while.

@axw Can we start to publish apm packages again?

@ruflin ruflin closed this as not planned Won't fix, can't repro, duplicate, stale Dec 29, 2022
@axw
Copy link
Member

axw commented Jan 9, 2023

I also agree with this. Shipping many prerelease version of the APM integration to the registry should no longer be a concern in v2. My memory is a little fuzzy on the specifics around the long thread of comments on #137759 (I think there were numerous offline conversations as well), but @axw can probably help clarify some of the motivations for no longer publishing APM to package storage at all.

We want the APM integration package:

  • to either be automatically installed (e.g. in Cloud), or always available to be installed (including in air-gapped environments)
  • to be exactly the same version as Kibana

This means users don't have to think about another version, and removing the possibility of skew means we can reduce the number of possible combinations of APM UI code & integration package version, improving supportability.

@axw Can we start to publish apm packages again?

If there's a benefit to users. Seems to me that #136617 could be fixed by preferring the bundled package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Development

No branches or pull requests

5 participants