Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Update Detections Related Integrations logic to install most recent compatible version #149606

Open
spong opened this issue Jan 26, 2023 · 2 comments
Open

[Security Solution] Update Detections Related Integrations logic to install most recent compatible version #149606

spong opened this issue Jan 26, 2023 · 2 comments
Labels
enhancement New value added to drive a business result Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules area Feature:Related Integrations Security Solution Detection Rules Related Integrations feature Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.

Comments

@spong
Copy link
Member

spong commented Jan 26, 2023 •
edited
Loading

Currently the Detections Related Integrations feature will generate a link for users to install the minimum concrete version satisfied by the provided related integration version. For best compatibility, we should be installing the most recent compatible version available.

Source:

kibana/x-pack/plugins/security_solution/public/detections/components/rules/related_integrations/integration_details.ts

Lines 150 to 154 in 21de750

const targetVersion = isVersionSatisfied
? installedVersion
: getMinimumConcreteVersionMatchingSemver(requiredVersion);
const targetUrl = buildTargetUrl(packageName, integrationName, targetVersion);

kibana/x-pack/plugins/security_solution/public/detections/components/rules/related_integrations/integration_details.ts

Lines 180 to 182 in 21de750

const getMinimumConcreteVersionMatchingSemver = (semverString: string): string => {
return semver.valid(semver.coerce(semverString)) ?? '';
};

For reference, see elastic/detection-rules#2495
@spong spong added triage_needed enhancement New value added to drive a business result Feature:Detection Rules Security Solution rules and Detection Engine Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Rule Management Security Detection Rule Management Team labels Jan 26, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@spong spong mentioned this issue Jan 26, 2023
Closed
@Mikaayenson Mikaayenson mentioned this issue Jan 26, 2023
Merged
3 tasks
@spong spong changed the title [Security Solution] Update Detections Required Integrations logic to install most recent compatible version [Security Solution] Update Detections Related Integrations logic to install most recent compatible version Jan 26, 2023
@banderror banderror added Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules area Feature:Related Integrations Security Solution Detection Rules Related Integrations feature and removed Feature:Detection Rules Security Solution rules and Detection Engine triage_needed labels Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New value added to drive a business result Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules area Feature:Related Integrations Security Solution Detection Rules Related Integrations feature Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@spong @banderror @elasticmachine