You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the PR a new 404 component was created. There's a Go Back button that when pushed runs history.back(). This might not be what we (APM) want. We think that the 404 page is going to be shown, in most cases, when a user bookmarked a URL that is no longer valid, and history.back() wouldn't make much sense since the user would leave kibana when the button is clicked.
We think the better approach would be exporting two new components:
buttonLabel: Where instead of Go back each consumer could customize what's displayed.
butonPath: The path where the button is going to redirect the user after the button is pushed.
@afgomez I'm tagging you because you implemented the first version of this component. WDYT?
The text was updated successfully, but these errors were encountered:
@cauemarcondes the component takes an actions prop where the consumer can specify any button/link. There is an example of this in the component's storybook.
I take this as a "bug" in the discoverability of the component's API. As a consumer of the component where would you have expected the documentation for this?
In the PR a new 404 component was created. There's a
Go Back
button that when pushed runshistory.back()
. This might not be what we (APM) want. We think that the 404 page is going to be shown, in most cases, when a user bookmarked a URL that is no longer valid, andhistory.back()
wouldn't make much sense since the user would leave kibana when the button is clicked.We think the better approach would be exporting two new components:
buttonLabel
: Where instead ofGo back
each consumer could customize what's displayed.butonPath
: The path where the button is going to redirect the user after the button is pushed.@afgomez I'm tagging you because you implemented the first version of this component. WDYT?
The text was updated successfully, but these errors were encountered: