Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Shared UX] rethink the "go back" button in the Not Found component #149622

Closed
cauemarcondes opened this issue Jan 26, 2023 · 4 comments
Closed
Labels
Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)

Comments

@cauemarcondes
Copy link
Contributor

In the PR a new 404 component was created. There's a Go Back button that when pushed runs history.back(). This might not be what we (APM) want. We think that the 404 page is going to be shown, in most cases, when a user bookmarked a URL that is no longer valid, and history.back() wouldn't make much sense since the user would leave kibana when the button is clicked.

We think the better approach would be exporting two new components:

  • buttonLabel: Where instead of Go back each consumer could customize what's displayed.
  • butonPath: The path where the button is going to redirect the user after the button is pushed.

@afgomez I'm tagging you because you implemented the first version of this component. WDYT?

@botelastic botelastic bot added the needs-team Issues missing a team label label Jan 26, 2023
@jughosta jughosta added the Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) label Jan 27, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Jan 27, 2023
@afgomez
Copy link
Contributor

afgomez commented Jan 30, 2023

@cauemarcondes the component takes an actions prop where the consumer can specify any button/link. There is an example of this in the component's storybook.

I take this as a "bug" in the discoverability of the component's API. As a consumer of the component where would you have expected the documentation for this?

@florent-leborgne
Copy link
Contributor

Hey, is there any UI copy needed on this issue? Just checking :)

@gbamparop
Copy link
Contributor

Closing this, we will keep the back button as is as discuss during refinement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)
Projects
None yet
Development

No branches or pull requests

6 participants