Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] replace custom error and warning icons with EUI version #149746

Closed
drewdaemon opened this issue Jan 27, 2023 · 2 comments
Closed

[Lens] replace custom error and warning icons with EUI version #149746

drewdaemon opened this issue Jan 27, 2023 · 2 comments
Assignees
@paulinashakirova
Labels
Feature:Lens impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:Visualizations Visualization editors, elastic-charts and infrastructure technical debt Improvement of the software architecture and operational architecture

Comments

@drewdaemon
Copy link
Contributor

#149262 adds a couple of custom icons to Lens code.

These have also be wrapped into EUI as of elastic/eui#6550

When a new version of EUI is released, we can replace the custom icons with the ones from EUI.
@drewdaemon drewdaemon added loe:small Small Level of Effort technical debt Improvement of the software architecture and operational architecture Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. labels Jan 27, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations)

@paulinashakirova paulinashakirova self-assigned this Nov 4, 2024
@paulinashakirova
Copy link
Contributor

I would like to close this issue because I see that this file has already been removed and the icons are now coming from Eui, as you can see in dimension_button_icon file.

@paulinashakirova paulinashakirova closed this as not planned Won't fix, can't repro, duplicate, stale Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paulinashakirova paulinashakirova

Labels
Feature:Lens impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:Visualizations Visualization editors, elastic-charts and infrastructure technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@drewdaemon @elasticmachine @paulinashakirova