Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet]: Dropdown to select GA version is not available when Display beta integrations is enabled under Integrations tab. #150141

Closed
amolnater-qasource opened this issue Feb 2, 2023 · 10 comments
Assignees
Labels
bug Fixes for quality problems that affect the customer experience impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Fleet Team label for Observability Data Collection Fleet team

Comments

@amolnater-qasource
Copy link

Kibana version: 8.7 Snapshot kibana cloud environment

Host OS and Browser version: All, All

Build details:

VERSION: 8.7 Snapshot
BUILD: 60311
COMMIT: ef00463019c0ebce609070d25cee6eed59a33909

Preconditions:

  1. 8.7 Snapshot kibana cloud environment should be available..

Steps to reproduce:

  1. Navigate to Integrations>Endpoint defend.
  2. Observe Endpoint version 8.6.1 is available.
  3. Navigate back to Browse tab and enable Display beta integrations.
  4. Observe Endpoint version 8.7.0-next is available.

As per our understanding for feature #122973, we expected a dropdown available for Endpoint where we will be able to select the GA version.

Impacted Testcase:
C168361

Screen Recording:

Browse.integrations.-.Integrations.-.Elastic.-.Google.Chrome.2023-02-02.14-20-07.mp4

Expected Result:
Dropdown to select GA version should be available when Display beta integrations is enabled under Integrations tab.

@amolnater-qasource amolnater-qasource added bug Fixes for quality problems that affect the customer experience impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Fleet Team label for Observability Data Collection Fleet team labels Feb 2, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@amolnater-qasource
Copy link
Author

@manishgupta-qasource Please review.

@manishgupta-qasource
Copy link

Secondary review for this ticket is Done

@criamico criamico self-assigned this Feb 8, 2023
@criamico
Copy link
Contributor

criamico commented Feb 8, 2023

I tried enabling the display beta integrations toggle on a clean instance of kibana and for me it doesn't happen:

Screen.Recording.2023-02-08.at.17.05.17.mov

By looking at the code:

https://github.com/juliaElastic/kibana/blob/13b381af78aa40ccbb14517405f9944895267245/x-pack/plugins/fleet/public/applications/integrations/sections/epm/screens/detail/index.tsx#L369-L379

it seems that the select could disappear in few cases, but the interesting ones are when latestGAVersion or latestPrereleaseVersion are falsy and when packageInfo.version !== latestGAVersion or packageInfo.version !== latestPrereleaseVersion.
The other two cases are straight forward (prereleaseIntegrationsEnabled === false, latestGAVersion === latestPrereleaseVersion).

One thing that I noticed doing a pretty quick test is that those versions start to get weird once an integration gets installed once and then uninstalled; it seems that the "leftover" assets mangle the versions and whole page behaves weirdly.

@criamico
Copy link
Contributor

criamico commented Feb 9, 2023

@amolnater-qasource I'm having trouble reproducing this bug. Could you test it again? If it happens again, could you let me know the detailed repro steps (for instance, if it was a first install of kibana, if the integration was installed for the first time or it was a reinstall)?

@amolnater-qasource
Copy link
Author

Hi @criamico

We have revalidated this issue on 8.7 Snapshot and 8.7 BC1 kibana cloud environment and had below observations[same for both]:

  • Endpoint version 8.7.0 is available on both the builds.
  • On enabling the Display beta integrations toggle, no beta version is available.
  • Further APM integration is installed by default and beta-preview version is also available.
  • However no dropdown is available for that, though the flow of opening the integration is different than other integrations.

We can close this issue if this is expected and we can track this on later builds.

Screen Recording:

Elastic.Defend.-.Integrations.-.Elastic.-.Google.Chrome.2023-02-10.11-27-57.mp4
Browse.integrations.-.Integrations.-.Elastic.-.Google.Chrome.2023-02-10.11-29-33.mp4

Build details:
BUILD: 60431
COMMIT: 99f69f7

Please let us know if anything else is required from our end.
Thanks

@criamico
Copy link
Contributor

Thanks @amolnater-qasource !

@juliaElastic I remember that you worked on this part, do you remember what was the expected behavior? The functionality here seems to be different than what expected, but it's not consistent. It seems to me that the fetched versions are not always the same, do you think it's possible?

@juliaElastic
Copy link
Contributor

juliaElastic commented Feb 10, 2023

For the Elastic Defend, there is a new 8.7.0 GA version published, so there is no newer beta version now, that is why there is no select available.
On the Elastic APM, it looks like 8.7.0-SNAPSHOT is installed and there is a newer preview available. Both of these are prerelease versions, so it is expected that there is no select showing up.

On the original issue, I think we might have a bug if the package is uninstalled, as you mentioned. We should investigate more.

One thing that I noticed doing a pretty quick test is that those versions start to get weird once an integration gets installed once and then uninstalled; it seems that the "leftover" assets mangle the versions and whole page behaves weirdly.

@criamico
Copy link
Contributor

Thanks Julia, I suspected that this is expected behavior. I'll close this bug and open a new one about the uninstalled package behavior to avoid confusion.

@criamico criamico closed this as not planned Won't fix, can't repro, duplicate, stale Feb 10, 2023
@criamico
Copy link
Contributor

criamico commented Feb 10, 2023

I checked the case when an integration is uninstalled. Unless the assets are also removed, the page appears as if the unistalled integration is still present. This screenshot is taken after uninstalling apm-8.4.2 but with the assets still installed:

Screenshot 2023-02-10 at 11 55 06

Once the assets get removed, the page shows the dropdown again:
Screenshot 2023-02-10 at 12 01 30

I think that this is correct behavior as well, even though it is a bit confusing for the customer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Development

No branches or pull requests

5 participants