Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cases] Refactor client functions #153546

Open
jonathan-buttner opened this issue Mar 23, 2023 · 2 comments
Open

[Cases] Refactor client functions #153546

jonathan-buttner opened this issue Mar 23, 2023 · 2 comments
Labels
Feature:Cases Cases feature Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) technical debt Improvement of the software architecture and operational architecture

Comments

@jonathan-buttner
Copy link
Contributor

The client functions that cases returns duplicate parameters that are needed for the case context when setting up the callbacks. We could refactor this to reduce the boilerplate code into a function that is passed to each callback that way we don't need to update a bunch of places whenever we need to add a new field to each of the callbacks or the case context.

Discussion: #152941 (comment)
@jonathan-buttner jonathan-buttner added Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:Cases Cases feature labels Mar 23, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops-cases (Feature:Cases)

@jonathan-buttner jonathan-buttner mentioned this issue Mar 23, 2023
Merged
@cnasikas cnasikas added the technical debt Improvement of the software architecture and operational architecture label Mar 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature:Cases Cases feature Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cnasikas @elasticmachine @jonathan-buttner