Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Unified Search][UX] user missing the apply query prompt #156603

Closed
drewdaemon opened this issue May 3, 2023 · 6 comments
Closed

[Unified Search][UX] user missing the apply query prompt #156603

drewdaemon opened this issue May 3, 2023 · 6 comments
Labels
Feature:Lens Feature:Unified search Unified search related tasks 🧊 iceboxed impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure usability

Comments

@drewdaemon
Copy link
Contributor

drewdaemon commented May 3, 2023

We had an internal report that a user can miss the prompt to apply their query before saving. Particularly, this was noticed when deleting the query and immediately saving. The user was also on a wide screen, which moved the update prompt further outside his field of visual focus.

Screen.Recording.2023-05-03.at.12.41.51.PM.mov

This user was editing Lens visualizations in bulk, so it could be that this issue is magnified or only present for his persona, but it does open the question: is there room to make this signifier more clear on large screens? Alternatively, does it ever make sense to do an auto-apply?

cc @MichaelMarcialis @gvnmagni

@drewdaemon drewdaemon added Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Unified search Unified search related tasks papercut Small "burr" in the product that we should fix. labels May 3, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations)

@stratoula
Copy link
Contributor

Cc @andreadelrio too as she has worked a lot on the unified search 😉

@andreadelrio
Copy link
Contributor

I seem to recall there's already been work done to make this button more visible, but we could consider showing a EuiBeacon in this case.

Alternatively, I wonder if we could show a confirm modal upon clicking Save for this scenario. Something like You have changes you haven't applied to the query you're about to save. [Apply changes and save] [Save as-is]

@MichaelMarcialis
Copy link
Contributor

Alternatively, does it ever make sense to do an auto-apply?

The auto-apply concept is interesting. I can see it not always being desirable (i.e. for performance intensive queries), but perhaps the addition of an option to auto-apply query changes on blur would be a nice enhancement (an option that is off by default, but can be turned on if users wish to move more rapidly).

In any case, assuming this isn't an extreme edge case (which is something we should confirm before proceeding), and we feel it's vital for users to know they can update their visualization with the latest query changes when saving, I like @andreadelrio's suggestion of a confirmation modal. However, if it is an extreme edge case (or we're unsure), I'd hesitate to make any changes that throw up roadblocks for the user during the save flow.

@stratoula
Copy link
Contributor

I am not a fan of the auto apply tbh. I feel that this is an extreme case although I am not opposed to a confirmation modal.

@stratoula stratoula added the impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. label Jun 1, 2023
@drewdaemon drewdaemon added usability and removed papercut Small "burr" in the product that we should fix. labels Aug 4, 2023
@dej611
Copy link
Contributor

dej611 commented Jul 24, 2024

In order to provide better transparency of priorities, issues that will not be prioritized within the next 24 months are being closed.

@dej611 dej611 closed this as not planned Won't fix, can't repro, duplicate, stale Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Lens Feature:Unified search Unified search related tasks 🧊 iceboxed impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure usability
Projects
None yet
Development

No branches or pull requests

6 participants