Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Uptime][Synthetics] Migrate all usages of EuiPage*_Deprecated #161416

Closed
Tracked by #161872
cee-chen opened this issue Jul 7, 2023 · 4 comments · Fixed by #162186
Closed
Tracked by #161872

[Uptime][Synthetics] Migrate all usages of EuiPage*_Deprecated #161416

cee-chen opened this issue Jul 7, 2023 · 4 comments · Fixed by #162186
Assignees
Labels
deprecation_warnings EUI Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability

Comments

@cee-chen
Copy link
Member

cee-chen commented Jul 7, 2023

👋 Hello from your friendly neighborhood EUI team! It's been almost a year since EUI's new EuiPageTemplate came out (if you can believe it), which means we're about a month away from the old deprecated EUI page template components being permanently removed.

Your team is being pinged in this issue because you have 3 usages of EuiPage*_Deprecated components, which you can find listed here:

How

  • Please see our new EuiPageTemplate guidelines and examples for suggestions on how to migrate over.
  • You can also see more examples of layout conversions in the original EuiPageTemplate PR:
    [Feature] EuiPage and EuiPageTemplate Updates eui#5768
  • Here's a quick conversion map of components that approximately translate to their new equivalents:
    • EuiPageTemplate_Deprecated -> EuiPageTemplate
    • EuiPageSideBar_Deprecated -> EuiPageSidebar or EuiPageTemplate.Sidebar
    • EuiPageContent_Deprecated -> EuiPageSection or EuiPageTemplate.Section
    • EuiPageContentBody_Deprecated -> Use EuiPageSection instead
    • EuiPageContentHeader_Deprecated -> Use EuiPageHeader instead
    • EuiPageContentHeaderSection_Deprecated -> Use EuiPageHeader instead

When

We'd really appreciate it if you could migrate your component usages over before or during August if possible.

If your team does not have the ability or bandwidth to perform this work by that time, please let us know. While we'd really appreciate as many teams as possible taking on this work so we're not having to touch hundreds of files by ourselves and in one go, the EUI team can potentially help you out - but we will need you to help QA that work and ensure your layouts look the same as before.

Thanks, and please feel free to reach out anytime with questions or help with migration!

@cee-chen cee-chen added Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability deprecation_warnings EUI labels Jul 7, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@elasticmachine
Copy link
Contributor

Pinging @elastic/eui-team (EUI)

@paulb-elastic
Copy link
Contributor

Thanks for bringing this to our attention @cee-chen, I'll add to our 8.10 plan (there's quite a few other things we have in 8.10, but will keep you updated if there's a risk)

@cee-chen
Copy link
Member Author

Thanks for taking care of this so quickly, y'all rock!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecation_warnings EUI Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants