Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Management] Indices list snapshot is unruly #16194

Closed
chrisronline opened this issue Jan 22, 2018 · 4 comments
Closed

[Management] Indices list snapshot is unruly #16194

chrisronline opened this issue Jan 22, 2018 · 4 comments
Assignees
Labels
chore Feature:Data Views Data Views code and UI - index patterns before 8.0 Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort

Comments

@chrisronline
Copy link
Contributor

I'm thinking we could keep a single snapshot and then do the rest of the unit tests with .find() and what not.

https://github.com/elastic/kibana/blob/master/src/core_plugins/kibana/public/management/sections/indices/create_index_pattern_wizard/components/step_index_pattern/components/indices_list/__tests__/__snapshots__/indices_list.test.js.snap

@deepansh946
Copy link
Contributor

I'm interested in solving this. Can you please explain a bit more about the issue?

@chrisronline
Copy link
Contributor Author

chrisronline commented Mar 4, 2018

Hi @deepansh946,

Thanks so much for offering to help!

Assuming you're familiar with snapshot testing, the snapshot test listed in the description is just a little too large for our liking and we'd like to reduce it. I see this happening in two ways:

  1. Encapsulate the componentry more so the snapshot isn't showing "unnecessary" components
  2. Move away from the amount of snapshots done and replace those with equivalent non-snapshot tests

Lemme know if you have any questions!

@chrisronline chrisronline reopened this Mar 4, 2018
@timroes timroes added Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages and removed :Management DO NOT USE labels Nov 27, 2018
@timroes timroes removed the good first issue low hanging fruit label Mar 1, 2019
@timroes timroes added Team:AppArch and removed Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Nov 4, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@lukeelmers lukeelmers added the Feature:Data Views Data Views code and UI - index patterns before 8.0 label Nov 4, 2020
@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort labels Jun 21, 2021
@ppisljar
Copy link
Member

ppisljar commented Aug 9, 2022

Thank you for contributing to this issue, however, we are closing this issue due to inactivity as part of a backlog grooming effort. If you believe this feature/bug should still be considered, please reopen with a comment.

@ppisljar ppisljar closed this as not planned Won't fix, can't repro, duplicate, stale Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Feature:Data Views Data Views code and UI - index patterns before 8.0 Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort
Projects
None yet
Development

No branches or pull requests

6 participants