Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global time range on Dashboards should be rounded #166210

Closed
thomasneirynck opened this issue Sep 11, 2023 · 3 comments
Closed

Global time range on Dashboards should be rounded #166210

thomasneirynck opened this issue Sep 11, 2023 · 3 comments
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features Feature:Embeddables Relating to the Embeddable system impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@thomasneirynck
Copy link
Contributor

thomasneirynck commented Sep 11, 2023

note this is a duplicate of #94280. It might be useful to track its impact on Dashboards specifically.

Time ranges are not rounded. This creates timestamps with ms precision. This prevents related contexts to share the same timerange (e.g. adding a filters in quick succession, navigating to and from a Dashboard, ...). Having consistent time-ranges are important because they better leverage query-caching on the Elasticsearch side.

Not entirely sure whether this is the responsibility of Dashboards/Embeddable system, rather than an issue with the individual widgets not performing the rounding (e.g. this is a Lens/Maps issue). Either way, rounding should occur. Since we likely want to have consistent date-ranges within each Dashboard context, my hunch is that the Embeddable system/Dashboarding should enforce rounding.

@thomasneirynck thomasneirynck added the bug Fixes for quality problems that affect the customer experience label Sep 11, 2023
@botelastic botelastic bot added the needs-team Issues missing a team label label Sep 11, 2023
@thomasneirynck thomasneirynck added the Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas label Sep 11, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Sep 11, 2023
@ThomThomson
Copy link
Contributor

I've been considering adding a rounding option to the Dashboard itself - which would allow authors to specify the amount of rounding, because IMO authors are the only people that know how accurate their data must be to be useful.

We would then just need to choose an appropriate default.

@ThomThomson ThomThomson added Feature:Dashboard Dashboard related features loe:medium Medium Level of Effort impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Feature:Embeddables Relating to the Embeddable system labels Sep 12, 2023
@thomasneirynck
Copy link
Contributor Author

duplicate of #94280.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features Feature:Embeddables Relating to the Embeddable system impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Development

No branches or pull requests

4 participants