Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] [Inline editing] Allow showing and adding filters and query bar in the Lens inline editor #179820

Open
mbondyra opened this issue Apr 2, 2024 · 5 comments
Labels
Feature:Lens impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:large Large Level of Effort Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@mbondyra
Copy link
Contributor

mbondyra commented Apr 2, 2024

Here are the features that full editor has that are missing in the inline editor:

  1. Adding filters (and also displaying what filters are applied)
  2. Adding query (and also displaying local query bar)
@mbondyra mbondyra added Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels Apr 2, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@stratoula
Copy link
Contributor

stratoula commented Apr 2, 2024

The reason I didnt add the globar query bar and filters or hadn't prioritized that is because we already have the filter by layer setting. I feel that the globar search (KQL and filters) is causing more confusion that helping the users.

But of course if filters / query is already being applied you should somehow display it in the user, we already do it on the panel level, maybe we can do something similar in the flyout

I don't know, I was just hoping that we can fix the experience here rather than moving things from the editor to the new flyout.

I would focus on improving the layers filtering experience, this global search has only created confusion.

@markov00 markov00 added loe:large Large Level of Effort impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. labels Apr 2, 2024
@MichaelMarcialis
Copy link
Contributor

Copying my comment from Slack, which I'm now seeing echos a bit of what @stratoula says above:

This may be slightly tangential, but I've always been curious if Lens visualizations should offer filtering at the individual layer level, rather than globally across the entire visualization. Doing so would give us an easy pathway to display layer-level filter editors in the flyout. It also gives the user more granular control over where their filtering is applied and to what data source. I think this is also a direction that we will ultimately need to take with ES|QL anyway (i.e. each layer having its own query)

@teresaalvarezsoler
Copy link

Agree with @MichaelMarcialis and @stratoula

Apart from the reasons mentioned, the global filters and query bar from dashboards already work with the inline editing, it would be very strange to add another global search bar within the flyout.
image

@markov00
Copy link
Member

markov00 commented Apr 8, 2024

What @MichaelMarcialis is correct, filtering should be done at the layer level, not through a shared UX.
A shared UX component should behave consistently across multiple pages, but here, the way is built in Lens, it includes the filtering capabilities within the data processing stage in Lens. The behaviour is different and overlap with the other way the query bar is used elsewhere.

Adding filters/query as part of the data processing is the way most data analytics platform works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Lens impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:large Large Level of Effort Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

6 participants