[Embeddables Rebuild] Clean up Add panel

[ThomThomson]

Cleanup

Blocked on #180059

Once we remove the legacy embeddable framework we should clean up the Dashboard add panel menu.

Goals:

• The add panel menu should no longer use legacy embeddable factories
• The add panel menu should no longer use vis aliases
• All entries in the add panel menu should come from the appropriate trigger ADD_PANEL_TRIGGER
• We should remove all grouping / rendering code from src/plugins/dashboard/public/dashboard_app/top_nav/editor_menu.tsx and move it into src/plugins/ui_actions/public. This way all actions can have the same render code. This can potentially be a sibling to /context_menu/build_eui_context_menu_panels.tsx, but will instead build some sort of list that can be used in a flyout to respect the designs from [Dashboard] Redesign Add Panel Experience #144418

[elasticmachine]

Pinging @elastic/kibana-presentation (Team:Presentation)

[cqliu1]

• We should remove all grouping / rendering code from src/plugins/dashboard/public/dashboard_app/top_nav/editor_menu.tsx and move it into src/plugins/ui_actions/public/context_menu/build_eui_context_menu_panels.tsx. This way all actions can have the same

Since we're switching from a context menu to a flyout layout for the add panel workflow (see #144418), we likely won't need to move to using build_eui_context_menu_panels.

[ThomThomson]

Good call @cqliu1 I hadn't considered this. I'll update the issue description.

I wonder if we can still move the code into the ui_actions plugin and have some sort of sibling method that respects the groupings (perhaps with accordions?) and creates a list.

IMO the code for transforming actions into usable EUI components belongs with the ui_actions plugin.

[nreese]

Changing LOE to large since this will require creating a new action for each visAlias registry type