Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] EUIfication of APM UI #18145

Closed
1 of 3 tasks
elasticmachine opened this issue Feb 15, 2018 · 6 comments
Closed
1 of 3 tasks

[APM] EUIfication of APM UI #18145

elasticmachine opened this issue Feb 15, 2018 · 6 comments
Labels
Team:APM All issues that need APM UI Team support v6.7.0

Comments

@elasticmachine
Copy link
Contributor

elasticmachine commented Feb 15, 2018

Concrete tasks

@elasticmachine
Copy link
Contributor Author

Original comment by @formgeist:

@elastic/apm-ui Would love to have your input on the above, and please add more if there's anything I'm missing. Question is whether we can PR the changes, or you need me to create some visual examples of how we might combine certain components to create x.

@elasticmachine
Copy link
Contributor Author

Original comment by @sqren:

Units
Move to Eui units system (resembles the existing for APM)
Colours
Move away from the existing variables.scss

We are currently waiting on javascript versions of the unit- and color-variables are available to us.

KUI -> EUI
I think we should start with the KUI to EUI migration. They are probably fairly easy.
We currently use KUI in these places: LINK REDACTED

@elasticmachine
Copy link
Contributor Author

Original comment by @formgeist:

@sqren Super useful link that 👍 I'll make a note that we're awaiting js versions of unit and colour vars.

@elasticmachine
Copy link
Contributor Author

Original comment by @sqren:

Use EuiLink for adding accessibility states like focus

Didn't you do this already @vanjacosic ?

@elasticmachine
Copy link
Contributor Author

Original comment by @vanjacosic:

I went through and replaced all KuiLink's and <a>'s with <EuiLink>. Though I won't vouch for the accessibility 😇

@elasticmachine elasticmachine added Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. Team:APM All issues that need APM UI Team support Meta labels Apr 24, 2018
@formgeist formgeist added [zube]: Impl Backlog and removed Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. Meta [zube]: Design Backlog labels Aug 22, 2018
@formgeist formgeist removed their assignment Jan 17, 2019
@formgeist
Copy link
Contributor

Closing in favor of #28928 and #25906

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:APM All issues that need APM UI Team support v6.7.0
Projects
None yet
Development

No branches or pull requests

3 participants