Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Console Monaco migration] Search bar is not displayed #186635

Closed
yuliacech opened this issue Jun 21, 2024 · 1 comment · Fixed by #188337
Closed

[Console Monaco migration] Search bar is not displayed #186635

yuliacech opened this issue Jun 21, 2024 · 1 comment · Fixed by #188337
Assignees
@ElenaStoeva
Labels
Feature:Console Dev Tools Console Feature Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more

Comments

@yuliacech
Copy link
Contributor

The keyboard shortcut CMD+f should activate a search bar: the feature works in Ace and it also works for Monaco in the playground. I think the Kibana version of Monaco disables the command pallette altogether (accessible by pressing F1 in the playground). If that is the case, we can add an explicit command to the keyboard shortcut CMD+f via addCommand or addAction.

Screenshots

Search bar in Ace

Screenshot 2024-06-21 at 16 43 23

Search bar in Monaco in the playground

Screenshot 2024-06-21 at 16 43 17
@yuliacech yuliacech added Feature:Console Dev Tools Console Feature Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more labels Jun 21, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-management (Team:Kibana Management)

@ElenaStoeva ElenaStoeva mentioned this issue Jul 11, 2024
Closed
@ElenaStoeva ElenaStoeva mentioned this issue Jul 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ElenaStoeva ElenaStoeva

Labels
Feature:Console Dev Tools Console Feature Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Monaco Editor] Add Search functionality ElenaStoeva/kibana
3 participants
@yuliacech @elasticmachine @ElenaStoeva