[ResponseOps][Rules] Remove unintended internal Find routes API with public access

[Zacqary]

Summary

Fixes #192957

Removes the internal/_find route from public access by moving the hard-coded options into the route builder functions.

[elasticmachine]

Pinging @elastic/response-ops (Team:ResponseOps)

[obltmachine]

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

• /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
• run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

[Zacqary]

@elasticmachine merge upstream

[cnasikas]

Could you please add a unit test (x-pack/plugins/alerting/server/routes/rule/apis/find/find_rules_route.test.ts) to be sure we register the correct routes with the correct access?

[cnasikas]

This call to the router will also be done when calling findInternalRulesRoute. This will register the GET /internal/alerting/rules/_find which we do not want. Should we add a check like

if (path !== INTERNAL_ALERTING_API_FIND_RULES_PATH) { /// rouer.get }

?

[Zacqary]

Restructured the if statement to be an if...else to handle this

[kibana-ci]

💔 Build Failed

• Buildkite Build
• Commit: 1057825
• Interpreting CI Failures

Failed CI Steps

• x-pack/test/alerting_api_integration/security_and_spaces/group1/config.ts
• x-pack/test/alerting_api_integration/security_and_spaces/group1/config.ts
• FTR Configs #55
• FTR Configs #55
• FTR Configs #66
• FTR Configs #66
• FTR Configs #84
• FTR Configs #84
• Serverless Rule Management - Security Solution Cypress Tests #3

Test Failures

• [job] [logs] x-pack/test/alerting_api_integration/security_and_spaces/group1/config.ts / alerting api integration security and spaces enabled Alerts - Group 1 alerts find with post internal superuser at space1 should filter out types that the user is not authorized to get retaining pagination
• [job] [logs] x-pack/test/alerting_api_integration/security_and_spaces/group1/config.ts / alerting api integration security and spaces enabled Alerts - Group 1 alerts find with post internal superuser at space1 should filter out types that the user is not authorized to get retaining pagination
• [job] [logs] FTR Configs #55 / Alerting create should create rules with mapped parameters
• [job] [logs] FTR Configs #55 / Alerting create should create rules with mapped parameters
• [job] [logs] FTR Configs #84 / Alerting update handle update alert request appropriately should handle update alert request appropriately
• [job] [logs] FTR Configs #84 / Alerting update handle update alert request appropriately should handle update alert request appropriately
• [job] [logs] FTR Configs #66 / ObservabilityApp Custom threshold rule saved the rule correctly
• [job] [logs] FTR Configs #66 / ObservabilityApp Custom threshold rule saved the rule correctly

Metrics [docs]

✅ unchanged

History

• 💔 Build #236763 failed ac11af5
• 💛 Build #236451 was flaky 5bcccb3

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream