Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ES|QL][Discover] Clean up the pinned filters while transitioning #193817

Merged
merged 3 commits into from
Sep 25, 2024

Conversation

stratoula
Copy link
Contributor

@stratoula stratoula commented Sep 24, 2024

Summary

Closes #193794

Cleans up the filters from the global state while transitioning to ES|QL

(this bug is not released)

Checklist

@stratoula stratoula added v9.0.0 backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Feature:ES|QL ES|QL related features in Kibana Team:ESQL ES|QL related features in Kibana v8.16.0 Feature:Discover Discover Application Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. labels Sep 24, 2024
@stratoula stratoula marked this pull request as ready for review September 24, 2024 07:13
@stratoula stratoula requested a review from a team as a code owner September 24, 2024 07:13
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-esql (Team:ESQL)

@stratoula stratoula added the release_note:skip Skip the PR/issue when compiling release notes label Sep 24, 2024
@stratoula
Copy link
Contributor Author

/ci

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
discover 813.9KB 813.9KB +41.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stratoula stratoula merged commit 933c69a into elastic:main Sep 25, 2024
24 checks passed
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 25, 2024
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Sep 25, 2024
…ng (#193817) (#194048)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[ES|QL][Discover] Clean up the pinned filters while transitioning
(#193817)](#193817)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Stratoula
Kalafateli","email":"efstratia.kalafateli@elastic.co"},"sourceCommit":{"committedDate":"2024-09-25T17:32:47Z","message":"[ES|QL][Discover]
Clean up the pinned filters while transitioning
(#193817)","sha":"933c69a867627e19b0150aa252b0af5d1d01cb06","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Discover","release_note:skip","v9.0.0","Team:DataDiscovery","backport:prev-minor","Feature:ES|QL","Team:ESQL","v8.16.0"],"title":"[ES|QL][Discover]
Clean up the pinned filters while
transitioning","number":193817,"url":"https://github.com/elastic/kibana/pull/193817","mergeCommit":{"message":"[ES|QL][Discover]
Clean up the pinned filters while transitioning
(#193817)","sha":"933c69a867627e19b0150aa252b0af5d1d01cb06"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193817","number":193817,"mergeCommit":{"message":"[ES|QL][Discover]
Clean up the pinned filters while transitioning
(#193817)","sha":"933c69a867627e19b0150aa252b0af5d1d01cb06"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Feature:Discover Discover Application Feature:ES|QL ES|QL related features in Kibana release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. Team:ESQL ES|QL related features in Kibana v8.16.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ES|QL]Pinned Filter gets retained in ES|QL mode
5 participants