Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Torq hostname identifying logic #194003

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

igorkheif
Copy link

@igorkheif igorkheif commented Sep 25, 2024

Summary

Summarize your PR. If it involves visual changes include a screenshot or gif.

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

Copy link

cla-checker-service bot commented Sep 25, 2024

💚 CLA has been signed

@pmuellr pmuellr added the Team:Detection Alerts Security Detection Alerts Area Team label Sep 25, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detection-engine (Team:Detection Alerts)

@pmuellr
Copy link
Member

pmuellr commented Sep 25, 2024

Is there an issue open for this? Not seeing one ...

@pmuellr pmuellr requested a review from a team September 25, 2024 17:44
@pmuellr
Copy link
Member

pmuellr commented Sep 25, 2024

I've added security-detections-response as a reviewer, as that team owns this code. After their review, response-ops will review ...

@cnasikas cnasikas added backport:skip This commit does not require backporting backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Oct 14, 2024
};
if (!isUrl(value)) return error;
const hostname = new URL(value).hostname;
const isTorqHostname = /^hooks(\.[a-z0-9]+)*\.torq\.io$/.test(hostname);
Copy link
Contributor

@michaelolo24 michaelolo24 Oct 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this was the only functional change in this PR. It looks good and the tests look great, thank you for adding them. Will leave the final review and approval to the @elastic/response-ops team as I'm not familiar with the torq.io url naming patterns. Thanks for the improvement @igorkheif !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) backport:skip This commit does not require backporting 💝community Team:Detection Alerts Security Detection Alerts Area Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants