-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing Torq hostname identifying logic #194003
base: main
Are you sure you want to change the base?
Conversation
💚 CLA has been signed |
Pinging @elastic/security-detection-engine (Team:Detection Alerts) |
Is there an issue open for this? Not seeing one ... |
I've added |
}; | ||
if (!isUrl(value)) return error; | ||
const hostname = new URL(value).hostname; | ||
const isTorqHostname = /^hooks(\.[a-z0-9]+)*\.torq\.io$/.test(hostname); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this was the only functional change in this PR. It looks good and the tests look great, thank you for adding them. Will leave the final review and approval to the @elastic/response-ops team as I'm not familiar with the torq.io url naming patterns. Thanks for the improvement @igorkheif !
Summary
Summarize your PR. If it involves visual changes include a screenshot or gif.
Checklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers