Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Kuery work with multiple index patterns #20457

Closed
timroes opened this issue Jul 4, 2018 · 4 comments
Closed

Make Kuery work with multiple index patterns #20457

timroes opened this issue Jul 4, 2018 · 4 comments
Labels
enhancement New value added to drive a business result Feature:Visualizations Generic visualization features (in case no more specific feature label is available)

Comments

@timroes
Copy link
Contributor

timroes commented Jul 4, 2018

Currently the toElasticsearchQuery expects to get one index pattern passed into it, when trying to convert Kuery into a ES query.

That's why currently TSVB, timelion and Vega don't work with Kuery (see #17722), because all of those visualizations do actually support using multiple (or none) index pattern at all.

I think we really should support a new query language for all visualizations, and not just a couple of them on a dashboard, since that will be very unintuitive for the user. Therefor we need to make Kuery also work with multiple index-pattern or none at all.

cc @elastic/kibana-discovery

@timroes timroes added :Discovery enhancement New value added to drive a business result labels Jul 4, 2018
@Bargs Bargs added the Feature:Visualizations Generic visualization features (in case no more specific feature label is available) label Jul 5, 2018
@Bargs
Copy link
Contributor

Bargs commented Jul 5, 2018

Or: TSVB, Timelion and Vega should use index patterns like the rest of Kibana. It's a discussion we can have, but KQL relies on index patterns for both scripted fields and wildcard field names. It would be equally weird if these features just broke on the affected visualizations.

@timroes
Copy link
Contributor Author

timroes commented Jul 5, 2018

Okay maybe I described that a bit confusing. Timelioe and Vega already understand index patterns and timelion already load them for scripted fields. The problem is, that we could potentially query against different index patterns in one chart. But I think I understand your answer that we should rather try to convert kql for each index pattern individually? (Like deeper down in the implementation)

@Bargs
Copy link
Contributor

Bargs commented Jul 5, 2018

Let's zoom about it some time, I'm not 100% sure if we're on the same page but from what you just said I'm thinking it may not be too difficult.

@timroes
Copy link
Contributor Author

timroes commented Jul 10, 2018

After syncing offline about that, I can close this. Kquery should always require an index pattern. In places where a visualization can have multiple index patterns (like timelion) we also need to issue multiple requests (or bundle them in an _msearch request), so we should simply compile Kquery for all those individual requests and their respective index patterns.

@timroes timroes closed this as completed Jul 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Visualizations Generic visualization features (in case no more specific feature label is available)
Projects
None yet
Development

No branches or pull requests

2 participants