You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
spalger opened this issue
Jul 17, 2018
· 0 comments
Labels
staleUsed to mark issues that were closed for being staleTeam:CoreCore services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
In order to test that some code using our TypeScript types is flagged by the typescript compiler, it is ideal to be able to commit a fixture that includes invalid TypeScript. By explicitly excluding fixtures from our TypeScript project/tsconfig.json these files won't cause our primary TS project to fail to build, but can still be checked in tests.
This presents an issue with linting though, as we use linter rules that require type information, and therefore must compile properly.
I think we should extend the way we lint our files to use a separate TSLint instance for fixtures that does not use the type-enabled rules and only applies rules for style and such. This way we can have nicely linted TS fixtures, but also have invalid TS fixtures for testing.
The text was updated successfully, but these errors were encountered:
staleUsed to mark issues that were closed for being staleTeam:CoreCore services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
In order to test that some code using our TypeScript types is flagged by the typescript compiler, it is ideal to be able to commit a fixture that includes invalid TypeScript. By explicitly excluding fixtures from our TypeScript project/tsconfig.json these files won't cause our primary TS project to fail to build, but can still be checked in tests.
This presents an issue with linting though, as we use linter rules that require type information, and therefore must compile properly.
I think we should extend the way we lint our files to use a separate TSLint instance for fixtures that does not use the type-enabled rules and only applies rules for style and such. This way we can have nicely linted TS fixtures, but also have invalid TS fixtures for testing.
The text was updated successfully, but these errors were encountered: