-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Functional test fixtures should be unzipped #21040
Comments
CC @nreese |
I think the "test fixtures" @cjcenizal is referring to are the esArchives which can be either .kibana index docs or data docs like logstash. I could see a case for wanting to search one of the .kibana archives for the name of a visualization or a dashboard. But it doesn't seem likely you'd want to grep for some logstash data? the es_archiver CLI has an |
I agree with @cjcenizal that all esArchives files containing Kibana saved objects should be stored uncompressed. This provides 2 really important benefits:
I can volunteer to close this and uncompress all data.json files for .kibana index. |
We're just starting the process to switch from esArchiver to kbnArchiver for importing saved objects for tests. kbnArchiver uses the saved object API. We should put our efforts into that change. @wayneseymour is working on it if you would like to coordinate with him. |
Just a place holder for now: |
It's impossible to grep the contents of the fixtures because they're all gzipped. Ideally, these files would all be unzipped so we can grep their contents more easily.
Here's a Python script which will unzip them all:
The text was updated successfully, but these errors were encountered: