Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*.test.ts files are never type checked #21766

Closed
jbudz opened this issue Aug 7, 2018 · 1 comment
Closed

*.test.ts files are never type checked #21766

jbudz opened this issue Aug 7, 2018 · 1 comment
Labels
PR sent Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@jbudz
Copy link
Member

jbudz commented Aug 7, 2018

ts-jest doesn't do type checking by default (but can be enabled with https://github.com/kulshekhar/ts-jest#ts-compiler--error-reporting)

We've been using our final build compilation step as our form of type checking but we remove test files before compiling typescript, so these are never checked.

Related #19325
Related #19105
@jbudz jbudz added the Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc label Aug 7, 2018
This was referenced Aug 7, 2018
Closed
Closed
@jbudz jbudz added the PR sent label Aug 8, 2018
@jbudz
Copy link
Member Author

jbudz commented Aug 10, 2018

Fixed in #19325

@jbudz jbudz closed this as completed Aug 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
PR sent Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jbudz