Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EuitoolTip setting state after unmounting in share top nav #22543

Closed
rashmivkulkarni opened this issue Aug 30, 2018 · 3 comments · Fixed by #22745
Closed

EuitoolTip setting state after unmounting in share top nav #22543

rashmivkulkarni opened this issue Aug 30, 2018 · 3 comments · Fixed by #22745
Labels
bug Fixes for quality problems that affect the customer experience

Comments

@rashmivkulkarni
Copy link
Contributor

**Kibana version:**master

Elasticsearch version: master

Server OS version: OSX

Browser version: Chrome

Original install method (e.g. download page, yum, from source, etc.): master

**Describe the bug:While I was testing scatter plot visualizations and had my console window open, I happened to see this huge warning in the console - It said Can't call setState (or forceUpdate) on an unmounted component. This is a no-op, but it indicates a memory leak in your application
Full console warning captured here :

warning.js:33 Warning: Can't call setState (or forceUpdate) on an unmounted component. This is a no-op, but it indicates a memory leak in your application. To fix, cancel all subscriptions and asynchronous tasks in the componentWillUnmount method.
    in EuiToolTip (created by EuiCopy)
    in EuiCopy (created by ShareUrlContent)
    in div (created by EuiForm)
    in EuiForm (created by ShareUrlContent)
    in ShareUrlContent (created by ShareContextMenu)
    in div (created by EuiContextMenuPanel)
    in div (created by EuiContextMenuPanel)
    in EuiContextMenuPanel (created by EuiContextMenu)
    in div (created by EuiContextMenu)
    in EuiContextMenu (created by ShareContextMenu)
    in ShareContextMenu
    in EuiMutationObserver (created by EuiPopover)
    in div (created by EuiPanel)
    in EuiPanel (created by EuiPopover)
    in div (created by FocusTrap)
    in FocusTrap (created by EuiPopover)
    in EuiPortal (created by EuiPopover)
    in div (created by EuiPopover)
    in EuiOutsideClickDetector (created by EuiPopover)
    in EuiPopover (created by EuiWrappingPopover)
    in EuiPortal (created by EuiWrappingPopover)
    in EuiWrappingPopover
printWarning @ warning.js:33
warning @ warning.js:57
warnAboutUpdateOnUnmounted @ react-dom.development.js:11170
scheduleWorkImpl @ react-dom.development.js:12103
scheduleWork @ react-dom.development.js:12055
enqueueSetState @ react-dom.development.js:6632
Component.setState @ react.development.js:242
EuiToolTip._this.hideToolTip @ tool_tip.js:136
EuiToolTip._this.testAnchor @ tool_tip.js:78
requestAnimationFrame (async)
EuiToolTip._this.testAnchor @ tool_tip.js:82
requestAnimationFrame (async)
EuiToolTip._this.testAnchor @ tool_tip.js:82
requestAnimationFrame (async)
EuiToolTip._this.testAnchor @ tool_tip.js:82
requestAnimationFrame (async)
EuiToolTip._this.testAnchor @ tool_tip.js:82
requestAnimationFrame (async)
EuiToolTip._this.testAnchor @ tool_tip.js:82
requestAnimationFrame (async)
EuiToolTip._this.testAnchor @ tool_tip.js:82
requestAnimationFrame (async)
EuiToolTip._this.testAnchor @ tool_tip.js:82
requestAnimationFrame (async)
EuiToolTip._this.testAnchor @ tool_tip.js:82
requestAnimationFrame (async)
EuiToolTip._this.testAnchor @ tool_tip.js:82
requestAnimationFrame (async)
EuiToolTip._this.testAnchor @ tool_tip.js:82
requestAnimationFrame (async)
EuiToolTip._this.testAnchor @ tool_tip.js:82
requestAnimationFrame (async)
EuiToolTip._this.testAnchor @ tool_tip.js:82
requestAnimationFrame (async)
EuiToolTip._this.testAnchor @ tool_tip.js:82
requestAnimationFrame (async)
EuiToolTip._this.testAnchor @ tool_tip.js:82
requestAnimationFrame (async)
EuiToolTip._this.testAnchor @ tool_tip.js:82
requestAnimationFrame (async)
EuiToolTip._this.testAnchor @ tool_tip.js:82
requestAnimationFrame (async)
EuiToolTip._this.testAnchor @ tool_tip.js:82
requestAnimationFrame (async)
EuiToolTip._this.testAnchor @ tool_tip.js:82
requestAnimationFrame (async)
EuiToolTip._this.testAnchor @ tool_tip.js:82
requestAnimationFrame (async)
EuiToolTip._this.testAnchor @ tool_tip.js:82
requestAnimationFrame (async)
EuiToolTip._this.testAnchor @ tool_tip.js:82
requestAnimationFrame (async)
EuiToolTip._this.testAnchor @ tool_tip.js:82
requestAnimationFrame (async)
EuiToolTip._this.testAnchor @ tool_tip.js:82
requestAnimationFrame (async)
EuiToolTip._this.testAnchor @ tool_tip.js:82
requestAnimationFrame (async)
EuiToolTip._this.testAnchor @ tool_tip.js:82
requestAnimationFrame (async)
EuiToolTip._this.testAnchor @ tool_tip.js:82
requestAnimationFrame (async)
EuiToolTip._this.testAnchor @ tool_tip.js:82
requestAnimationFrame (async)
EuiToolTip._this.testAnchor @ tool_tip.js:82
requestAnimationFrame (async)
EuiToolTip._this.testAnchor @ tool_tip.js:82
requestAnimationFrame (async)
EuiToolTip._this.testAnchor @ tool_tip.js:82
requestAnimationFrame (async)
EuiToolTip._this.testAnchor @ tool_tip.js:82
requestAnimationFrame (async)
EuiToolTip._this.testAnchor @ tool_tip.js:82

It didn't hamper anything, but application memory leak warning is not good.

screen shot 2018-08-30 at 6 31 01 am

@rashmivkulkarni rashmivkulkarni added bug Fixes for quality problems that affect the customer experience Feature:Visualizations Generic visualization features (in case no more specific feature label is available) labels Aug 30, 2018
@timroes
Copy link
Contributor

timroes commented Sep 5, 2018

cc @elastic/kibana-sharing It seems you recently changed the Sharing dialog in all applications, which seem to sometimes throw the above issue. I added the :Sharing label here.

@Rasroh I am also unable to reproduce this, could you provide some additional information what buttons, etc. you are actually clicking when this happens, have you opened the "Share" menu beforehand?

@nreese
Copy link
Contributor

nreese commented Sep 5, 2018

@timroes I was able to reproduce. Open the share top nav. Open either share option, "Embed code" or "Permalinks". Mouse over the ? to open the tooltip. Press esc to close the popover.

Looks like the bug is in EuiToolTip. I will see if I can put a fix together.

@nreese
Copy link
Contributor

nreese commented Sep 5, 2018

Created elastic/eui#1163 to resolve the issue. I will close this issue once a version of EUI with the fix has been merged into Kibana

@nreese nreese changed the title warning seen on visualization page coming from Euitooltip- which indicated that application had a memory leak EuitoolTip setting state after unmounting in share top nav Sep 5, 2018
@nreese nreese added EUI and removed Feature:Visualizations Generic visualization features (in case no more specific feature label is available) triage_needed labels Sep 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants