Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing the timepicker resets the dirty status of a vis on dashboards #22876

Closed
marius-dr opened this issue Sep 10, 2018 · 1 comment
Closed

Changing the timepicker resets the dirty status of a vis on dashboards #22876

marius-dr opened this issue Sep 10, 2018 · 1 comment
Assignees
@ThomThomson
Labels
bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:needs-research This issue requires some research before it can be worked on or estimated Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas triage_needed

Comments

@marius-dr
Copy link
Member

Kibana version: 6.4.0

Browser version: Firefox 61.0.2

Describe the bug: The reporting "please save your work" message is not consistent with the actions that the user takes.
If you take a saved dashboard (where reporting works) and click on "Edit" to go in Dashboard edit mode, you'll get the Please save your work before generating a report. error, even if you did no change.
If you change the timepicker now, it resets the whole dirty status for visualizations and you can generate a report again, while in Edit mode. One or both of these behaviors are wrong.

Steps to reproduce:

  1. Open a Metricbeat System dashboard.
  2. Select "Report". It should let you generate a report.
  3. Click on "Edit" in the dashboard toolbar.
  4. Select "Report". It won't let you generate a report unless you save.
  5. Without saving, change the range in the timepicker.
  6. Select "Report". It will now let you generate a report.
@marius-dr marius-dr added bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead labels Sep 10, 2018
@timroes timroes added Team:Visualizations Visualization editors, elastic-charts and infrastructure and removed Team:Visualizations Visualization editors, elastic-charts and infrastructure :Sharing enhancement New value added to drive a business result labels Sep 13, 2018
@timroes timroes removed the (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead label Jul 18, 2019
@timroes timroes added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas and removed Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Oct 7, 2020
@kmartastic kmartastic added impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:needs-research This issue requires some research before it can be worked on or estimated labels Mar 5, 2021
@ThomThomson
Copy link
Contributor

This is no longer the case! You can now generate reports in unsaved dashboards, and the unsaved changes calculation has been made much better and more stable in #97941

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ThomThomson ThomThomson

Labels
bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:needs-research This issue requires some research before it can be worked on or estimated Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas triage_needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@timroes @marius-dr @bhavyarm @ThomThomson @kmartastic