[Bug] Vega visualizations renders 2 controls

[cchaos]

Kibana version: Master

Server OS version: All

Browser version: All

Describe the bug: Vega visualization adds two control areas, one is slightly hidden.

Steps to reproduce:

1. Create a new Vega visualization
2. Copy and paste this json
3. Look for the cutoff control at the bottom

Expected behavior:
Only one of these control areas should be rendered.

Screenshots (if relevant):

[cchaos]

cc @nyurik

[timroes]

As a reminder: There is code specific to this bug in src/core_plugins/vega/public/_vega_vis.scss (once #23513 is merged) that should be removed together with the fix for this issue.

[lizozom]

@cchaos seems like the bug is resolved. Can you confrm?

[nyurik]

The issue is still there - tested after migrating to the latest Vega with #30628

To reproduce, use some vega graph from docs, e.g. arc mark, move the mouse over the graph, click view source, and copy it to Kibana. Examine the HTML tree - observe there are two copies of the same block - one next to the canvas, and one in a separate dedicated controls container.

[lizozom]

The issue is due to a bug in Vega: Adding a tooltip handler to a plot that uses a custom controls area, resets the plugin, and starts using the internal controls area.

I opened a bug on the vega project, and it will be solved in Vega 5.

[nyurik]

Also note that controls have a few customization options (signal binding placement) that might need some visualization/styling cleanup. This might only tangentially be related to this issue.

[stratoula]

I think this should close as we upgraded to vega5, cant reproduce it either cc @lizozom