Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] DT Span flyout design fixes #23568

Closed
7 tasks done
jasonrhodes opened this issue Sep 27, 2018 · 5 comments
Closed
7 tasks done

[APM] DT Span flyout design fixes #23568

jasonrhodes opened this issue Sep 27, 2018 · 5 comments
Assignees
Labels
Team:APM - DEPRECATED Use Team:obs-ux-infra_services. v6.5.0

Comments

@jasonrhodes
Copy link
Member

jasonrhodes commented Sep 27, 2018

Clicking on a span in the waterfall timeline view should open a flyout with that span's details. This flyout currently exists but needs some work to clean up.

  • Use EUI for headers;
  • Fix margin for sticky properties;
  • Move Discover button and change copy (should it also change style?)
  • Add separator lines above and below sticky props
  • Add service and transaction name (including links)

Copy fixes:

  • “Stacktraces” -> “Stack traces”
  • “DB Statement” -> “Database statement”

InVision prototype

Note: This ticket continues work from #22763

@jasonrhodes jasonrhodes added Team:APM - DEPRECATED Use Team:obs-ux-infra_services. [zube]: Inbox labels Sep 27, 2018
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui

@sorenlouv sorenlouv changed the title [APM] DT Span flyout [APM] DT Span flyout design fixes Oct 16, 2018
@jasonrhodes
Copy link
Member Author

jasonrhodes commented Oct 17, 2018

@formgeist if you can pull up the apm/dt branch, it would be nice if you could outline specifics of what if anything needs to be addressed for design clean up in the following places:

  • here in the span flyout
  • in the transaction flyout
  • on the transaction group page in the sample section

If it makes sense we can just change the title of this issue to include all of those and knock them all out at once or if they are small enough, inside of another ticket. If folks think we need multiple issues for this work, that's fine too, just don't want the other places to get lost.

@sorenlouv
Copy link
Member

sorenlouv commented Oct 17, 2018

I've updated the outstanding tasks for this issue, and will start working on them.

@jasonrhodes It probably makes sense for you to do the same for the transaction flyout on https://zube.io/elastic/apm/c/38913

@sorenlouv
Copy link
Member

@formgeist Let me know if you have any additions to the above tasks.

@formgeist
Copy link
Contributor

@jasonrhodes The list looks fine, I think the most important stuff is getting the service and transaction name displayed with links so you can navigate between your APM services etc. That makes the navigation path easier for the user. In regards to style polish let's leave that for later. I'll do a redline run through when we're a bit closer to catch them all, and then we can see how much we implement before FF.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:APM - DEPRECATED Use Team:obs-ux-infra_services. v6.5.0
Projects
None yet
Development

No branches or pull requests

5 participants