Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Monitoring] All % graphs should start at 0 on the y-axis #23839

Open
Tracked by #65
chrisronline opened this issue Oct 4, 2018 · 3 comments
Open
Tracked by #65

[Monitoring] All % graphs should start at 0 on the y-axis #23839

chrisronline opened this issue Oct 4, 2018 · 3 comments
Labels
Feature:ElasticCharts Issues related to the elastic-charts library good first issue low hanging fruit Team:Monitoring Stack Monitoring team

Comments

@chrisronline
Copy link
Contributor

chrisronline commented Oct 4, 2018

This came from a comment in this PR where we shouldn't show negative values on the y-axis for graphs showing percentages.

I'll go back and add the list of known affected graphs later.

It might be as easy as applying this logic for the y-axis too

@chrisronline chrisronline added Team:Monitoring Stack Monitoring team good first issue low hanging fruit labels Oct 4, 2018
@pohzipohzi
Copy link

Hi @chrisronline . I'm interested in working on this issue. I tried to play around with the charts and I think I may have found the fix. I'm not super familiar with kibana graphs - are "graphs showing percentages" always flot charts? I made a one line PR for this but do let me know if anything needs to change

@chrisronline
Copy link
Contributor Author

Hi @pohzipohzi

Thanks for the contribution! I will take a look at this soon and get back to you.

Thanks again!

@markov00
Copy link
Member

hi @chrisronline does this issue still persist?
If you are using elastic/charts this issue should not be present. If so can we close it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:ElasticCharts Issues related to the elastic-charts library good first issue low hanging fruit Team:Monitoring Stack Monitoring team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants