Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong method called - possible memory leak #24574

Closed
szydan opened this issue Oct 25, 2018 · 2 comments · Fixed by #24575
Closed

Wrong method called - possible memory leak #24574

szydan opened this issue Oct 25, 2018 · 2 comments · Fixed by #24575
Labels
bug Fixes for quality problems that affect the customer experience Feature:TSVB TSVB (Time Series Visual Builder) Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@szydan
Copy link
Contributor

szydan commented Oct 25, 2018

I think in these lines and .off should be called instead of .on
https://github.com/elastic/kibana/blob/master/src/core_plugins/metrics/public/visualizations/components/flot_chart.js#L69
https://github.com/elastic/kibana/blob/master/src/core_plugins/metrics/public/visualizations/components/flot_chart.js#L70
@timroes
Copy link
Contributor

timroes commented Oct 25, 2018

Excellent finding. Would you be able to setup a PR changing those to off?

@timroes timroes added bug Fixes for quality problems that affect the customer experience Feature:TSVB TSVB (Time Series Visual Builder) Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Oct 25, 2018
@szydan
Copy link
Contributor Author

szydan commented Oct 25, 2018

Coming shortly

@szydan szydan mentioned this issue Oct 25, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience Feature:TSVB TSVB (Time Series Visual Builder) Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Corrected wrong calls from .on to .off szydan/kibana
2 participants
@timroes @szydan