Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import workpad dialog is not getting announced in screenreader in Canvas #25016

Closed
bhavyarm opened this issue Nov 1, 2018 · 3 comments
Closed

Import workpad dialog is not getting announced in screenreader in Canvas #25016

bhavyarm opened this issue Nov 1, 2018 · 3 comments
Assignees
@poffdeluxe
Labels
bug Fixes for quality problems that affect the customer experience Feature:Canvas impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. loe:small Small Level of Effort Project:Accessibility Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas WCAG A

Comments

@bhavyarm
Copy link
Contributor

bhavyarm commented Nov 1, 2018

Kibana version: 6.5.0 BC1

Server OS version: os x

Browser version: chrome latest

Browser OS version: os x

Original install method (e.g. download page, yum, from source, etc.): from staging

Describe the bug: Import workpad diaglog box is getting announced as choose file button in screenreader. This doesn't give context to non-sighted user.

Steps to reproduce:

  1. Use voiceover
  2. tab through canvas workpads listing page
  3. import dialog box gets announced as choose file instead of import workpad json

impor_workpad
@bhavyarm bhavyarm added bug Fixes for quality problems that affect the customer experience Project:Accessibility Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas labels Nov 1, 2018
@rayafratkina rayafratkina mentioned this issue Nov 1, 2018
Closed
18 tasks
@bhavyarm bhavyarm added the WCAG A label Nov 6, 2018
@cqliu1 cqliu1 added the loe:small Small Level of Effort label Mar 19, 2019
@timductive
Copy link
Member

It looks like we need a prop from EUI to add an aria-label to this form control: https://elastic.github.io/eui/#/forms/form-controls @ryankeairns is that right?

@poffdeluxe
Copy link
Contributor

I believe this is fixed by the EUI PR here: elastic/eui#2919
It adds a labelled by attribute to the prompt

@poffdeluxe poffdeluxe reopened this Jul 29, 2020
@clintandrewhall clintandrewhall added the impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. label Mar 1, 2021
@crob611
Copy link
Contributor

crob611 commented Nov 17, 2021

Just tested on Main and it is announced properly. Closing for now.

@crob611 crob611 closed this as completed Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@poffdeluxe poffdeluxe

Labels
bug Fixes for quality problems that affect the customer experience Feature:Canvas impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. loe:small Small Level of Effort Project:Accessibility Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas WCAG A
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@clintandrewhall @crob611 @poffdeluxe @timroes @timductive @cqliu1 @bhavyarm