Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] consider Transaction.marks.agent an option property #25712

Closed
hmdhk opened this issue Nov 15, 2018 · 2 comments
Closed

[APM] consider Transaction.marks.agent an option property #25712

hmdhk opened this issue Nov 15, 2018 · 2 comments
Assignees
Labels
Team:APM - DEPRECATED Use Team:obs-ux-infra_services.

Comments

@hmdhk
Copy link

hmdhk commented Nov 15, 2018

Transaction.marks.agent is an optional property and might be missing in certain types of Transactions.

The APM UI currently considers this property as required and throws an TypeError: "can't convert undefined to object" if it's missing.

@hmdhk hmdhk added the Team:APM - DEPRECATED Use Team:obs-ux-infra_services. label Nov 15, 2018
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui

@sorenlouv
Copy link
Member

agent should be marked as optional in:

https://github.com/sqren/kibana/blob/f0dad8bc1451e3e32487bb1473d472e7a57491ed/x-pack/plugins/apm/typings/Transaction.ts#L39-L43

like:

interface Marks {
  agent?: {
    [name: string]: number;
  };
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:APM - DEPRECATED Use Team:obs-ux-infra_services.
Projects
None yet
Development

No branches or pull requests

5 participants