Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent linting between Canvas and Kibana #25753

Closed
stacey-gammon opened this issue Nov 15, 2018 · 2 comments
Closed

Consistent linting between Canvas and Kibana #25753

stacey-gammon opened this issue Nov 15, 2018 · 2 comments
Assignees
Labels
chore Feature:Canvas loe:small Small Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@stacey-gammon
Copy link
Contributor

Seems to be some custom linting rules in the Canvas repo that contradict the Kibana style guide. Only known one I'm aware of is

if (true) {
 console.log('hi');
}

changing to

if (true) console.log('hi');

Another oddity is the file naming, sometimes there is pascalCase.js, sometimes nocapitals.js and sometimes underscores_too.js. Since the rest of Kibana uses underscores, canvas probably should too. Not sure why the linter isn't catching that though, looks like no custom rule for it.

@stacey-gammon stacey-gammon added chore Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas labels Nov 15, 2018
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-canvas

@timductive
Copy link
Member

Closing based on fix and discussion in linked PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Feature:Canvas loe:small Small Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Development

No branches or pull requests

6 participants