Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[i18n] Check usage of FormattedNumber instead of Numeral JS #27475

Closed
maryia-lapata opened this issue Dec 19, 2018 · 8 comments
Closed

[i18n] Check usage of FormattedNumber instead of Numeral JS #27475

maryia-lapata opened this issue Dec 19, 2018 · 8 comments
Labels
enhancement New value added to drive a business result Feature:FieldFormatters impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Project:i18n Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@maryia-lapata
Copy link
Contributor

Check whether we can use FormattedNumber instead of Numeral JS and whether we should set the locale for Numeral JS according to i18n.locale preference.

Note: There is a field Formatting locale in Advanced settings that is related to locale for Numeral JS

/cc @azasypkin

@maryia-lapata maryia-lapata changed the title [i18n] Check usage of FormattedNumber instead of Numeral JS [i18n] Check usage of FormattedNumber instead of Numeral JS Dec 19, 2018
@azasypkin azasypkin added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Dec 19, 2018
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app

@markov00
Copy link
Member

related to : #25993 and #8583

@azasypkin
Copy link
Member

Also dates and numbers in node won't be formatted properly without solving #20288

@jinmu03 jinmu03 added the enhancement New value added to drive a business result label Feb 25, 2019
@Bamieh
Copy link
Member

Bamieh commented Apr 16, 2019

I tried working on this issue and it seems that it needs a lot of time to fully resolve. I prefer to delay it to see how critical it is given the amount of time it will require to resolve.

@wylieconlon
Copy link
Contributor

Left this comment in a few other places, but we can start targeting 8.0 for usage of Intl.NumberFormat because it will be supported in node by then. It might not be able to replace our existing usage immediately, but we can start transitioning.

@timroes timroes added Team:AppArch and removed Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Mar 27, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@Bamieh Bamieh removed their assignment Mar 31, 2020
@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort labels Jun 15, 2021
@exalate-issue-sync exalate-issue-sync bot added loe:medium Medium Level of Effort and removed loe:small Small Level of Effort labels Jun 22, 2021
@exalate-issue-sync exalate-issue-sync bot added loe:small Small Level of Effort and removed loe:medium Medium Level of Effort labels Jan 14, 2022
@ppisljar
Copy link
Member

Thank you for contributing to this issue, however, we are closing this issue due to inactivity as part of a backlog grooming effort. If you believe this feature/bug should still be considered, please reopen with a comment.

@ppisljar ppisljar closed this as not planned Won't fix, can't repro, duplicate, stale Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:FieldFormatters impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Project:i18n Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Development

No branches or pull requests

9 participants