Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Drag and drop handling #36189

Closed
flash1293 opened this issue May 7, 2019 · 5 comments
Closed

[Lens] Drag and drop handling #36189

flash1293 opened this issue May 7, 2019 · 5 comments
Assignees
Labels
Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@flash1293
Copy link
Contributor

  • Extend APIs where necessary
  • Registers global context for drag and drop handling
  • Add drag and drop for indexpattern datasource

Has to work without assuming a single react tree (because of agnostic rendering)

@flash1293 flash1293 added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label May 7, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app

@chrisdavies
Copy link
Contributor

Wylie and I discussed a bit yesterday, and decided to implement the most basic feature set we need and nothing more. So, the current PR does not provide out-of-the-box mechanisms for re-ordering. It's just drag / drop / change some CSS classes if the drop target is active or supports the dragged item.

@chrisdavies
Copy link
Contributor

As noted by Joe, we'll need to look into cross-platform issues, such as drag and drop on mobile.

There are some polyfills available which we can investigate when the time comes.

@flash1293
Copy link
Contributor Author

@chrisdavies I think we can add a separate :Lens issue for that

@chrisdavies
Copy link
Contributor

I think this is addressed well enough by the PR mentioned above. Closing for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

3 participants