Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] XY chart styling control #36208

Closed
flash1293 opened this issue May 7, 2019 · 3 comments
Closed

[Lens] XY chart styling control #36208

flash1293 opened this issue May 7, 2019 · 3 comments
Assignees
Labels
Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@flash1293
Copy link
Contributor

flash1293 commented May 7, 2019

  • Toggle axis display
  • Use existing index pattern formatters
  • Choose color scheme from predefined
@flash1293 flash1293 added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label May 7, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app

@flash1293 flash1293 self-assigned this Jun 13, 2019
@flash1293
Copy link
Contributor Author

flash1293 commented Jun 24, 2019

After sync with the app architecture team, we decided to pass the formatting information to the visualization by attaching it as meta information to the column data type which can be used in the toExpression function of the visualization.

To pass it to the renderer we should use a unified "dimension" data type for the arguments which can be re-used across all visualization expression renderers (this will also make integration with the current visualize infrastructure easier because it's following the same approach). By doing so we can treat formatting information exactly like labels and don't have to change things about the data table type just yet which keeps Lens usage of expressions closer to current visualize and Canvas.

Default formatting options passed as meta information as part of the data table column (see #38874 ) will be postponed till canvas also has formatting support and patterns for how to structure this information have emerged to not prematurely pollute the data table type with Lens-specific things.

@flash1293
Copy link
Contributor Author

This is done besides the color scheme which we decided to not include into beta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

2 participants