Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Infra + Logs UI] New platform client shim #39080

Closed
2 of 16 tasks
jasonrhodes opened this issue Jun 17, 2019 · 1 comment
Closed
2 of 16 tasks

[Infra + Logs UI] New platform client shim #39080

jasonrhodes opened this issue Jun 17, 2019 · 1 comment
Assignees
Labels
Feature:Logs UI Logs UI feature Feature:Metrics UI Metrics UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.4.0

Comments

@jasonrhodes
Copy link
Member

jasonrhodes commented Jun 17, 2019

As part of our new platform migration , we need to implement the core shim.

See here: https://github.com/elastic/kibana/blob/master/src/core/MIGRATION.md#introduce-new-plugin-definition-shim

AC:

  • Infra and logs UI application start up (client-side) are both using a new platform core shim
  • Implementation has been checked by the new platform team (@skaapgif probably?)

See here for more details on how this was done in APM: #34531

Notes:

Here is a list of dependencies we rely on that need to be added to the shim so that we can become fully NP-compatible. There are 72 instances of importing from ui/* across 49 files.

  • ui/capabilities (21) ??

  • ui/index_patterns (14) -> data.indexPatterns still in progress?

  • ui/chrome (13)

    • import { Badge } from 'ui/chrome/api/badge'; + chrome.badge.set()
    • import { Breadcrumb } from 'ui/chrome/api/breadcrumbs'; + chrome.breadcrumb.set()
    • chrome.helpExtension.set()
    • chrome.addBasePath()
    • chrome.getUiSettingsClient().get('theme:darkMode');
  • ui/kfetch (7) -> core.http

  • ui/autocomplete_providers (3)

  • ui/routes (3)

  • ui/vis/lib/timezone (2)

  • ui/utils/query_string (2)

  • ui/modules (2)

  • ui/i18n (1)

  • ui/notify (1) toastNotifications -> core.notifications

  • ui/registry/feature_catalogue (1)

  • ui/new_platform (2)

@jasonrhodes jasonrhodes added Feature:Metrics UI Metrics UI feature Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services labels Jun 17, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/infra-logs-ui

@jasonrhodes jasonrhodes self-assigned this Jun 17, 2019
@jasonrhodes jasonrhodes changed the title [Infra + Logs UI] New platform core shim [Infra + Logs UI] New platform client shim Sep 5, 2019
@zube zube bot removed the [zube]: Done label Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Logs UI Logs UI feature Feature:Metrics UI Metrics UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.4.0
Projects
None yet
Development

No branches or pull requests

3 participants