Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort terms by filter ratio column #41107

Closed
flash1293 opened this issue Jul 15, 2019 · 4 comments
Closed

Sort terms by filter ratio column #41107

flash1293 opened this issue Jul 15, 2019 · 4 comments
Labels
Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@flash1293
Copy link
Contributor

A terms column can be sorted by the value of another column. This is done server side and can change which terms actually occur in the resulting table because of the size limit. This does not work for filter ratio columns because they are calculated on the client side.

We could do a client side sorting for filter ratio columns, but then we would need a second sorting column for the server side sorting to decide which terms to show if there are more terms than the size limit.

Another possibility is to simply not allow sorting by filter ratio columns and only enable this by editing the expression directly.

ping @chrisdavies @wylieconlon @timroes @cchaos

@cchaos
Copy link
Contributor

cchaos commented Jul 15, 2019

¯\_(ツ)_/¯ haha --- Doesn't seem like I can contribute much to the conversation there.

@flash1293
Copy link
Contributor Author

@cchaos Maybe I pinged you prematurely - I did so because I don't know how to make it clear in the UI that there are two types of sortings (client side and server side) if we follow this approach.

@timroes timroes added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Jan 9, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@wylieconlon
Copy link
Contributor

I'm going to close this issue since we don't actually have a filter ratio implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

5 participants