Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Add a github bot for auto backport #41321

Closed
zfy0701 opened this issue Jul 17, 2019 · 5 comments
Closed

[Feature request] Add a github bot for auto backport #41321

zfy0701 opened this issue Jul 17, 2019 · 5 comments
Labels
Team:Operations Team label for Operations Team

Comments

@zfy0701
Copy link
Contributor

zfy0701 commented Jul 17, 2019

Describe the feature:

Currently, for each PR we manually run backport, the process is time-consuming and error-prone. It would be nice if we could add github bot to auto backport PRs.

Describe a specific use case for the feature:
For the main PR, we will already label it with version like 7.3, 8.0, the bot could look at the newly submitted PR, decide if it need to be backported, and create backport PR automatically, and notify the author if the backport PR created successfully or not, for backport PR, we could also let the bot to automatically submit once CI passes

@tylersmalley
Copy link
Contributor

We used to have this using Jasper. I can't recall at the moment the exact reason for removing it but those issues might be resolved by Sorens backport tool.

@epixa, do you recall the downfall of the Jasper backporter?

@tylersmalley tylersmalley added the Team:Operations Team label for Operations Team label Jul 17, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations

@spalger
Copy link
Contributor

spalger commented Jul 17, 2019

IIRC Jasper suffered from uptime issues, and also it tried to assist with backports that had conflicts but that turned out to be pretty difficult to understand. The local backport script definitely requires that people are on top of which PRs to backport, but I personally think that running the backports locally is a pretty efficient way to take care of them (especially when there is a conflict to resolve in the older branch).

That being said, I definitely think we could come up with some sort of backport verifier that pings people when they forget to backport a PR.

@epixa
Copy link
Contributor

epixa commented Jul 17, 2019

We’ve had two remote backport tools, jarvis and jasper. Both ultimately failed because it was too cumbersome to deal with git conflicts with such a system - or at least with each of those systems.

Jarvis would just fail on conflict and leave it up to you to handle. Jasper would commit instructions and scripts for reconciling conflicts and pushing the fix to the backport PR.

In both cases, some people just ignored the tools entirely because it was easier for them to reason about potential conflicts if they just handled it manually with git for all of their backports.

I’m not against such a tool, but I think there’s very high risk of failure here.

@spalger
Copy link
Contributor

spalger commented Mar 3, 2021

This is in beta testing mode right now, if you include the auto-backport label to a PR it will be automatically backported via a Github action.

@spalger spalger closed this as completed Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Operations Team label for Operations Team
Projects
None yet
Development

No branches or pull requests

5 participants