(Accessibility) Kibna Logs - Control Changes do not notify the user

[barlowm]

Steps to reproduce (assumes NVDA or JAWS Screen Reader or similar)

NVDA Screen Reader is a free Screen Reader which can be downloaded from the NV Access Website
Deque has a page of shortcuts for help on using NVDA as well as a Quick Reference Guide for using NVDA

Steps to reproduce

1. Navigate to the Kibana Logs page

2. Navigate to the "Customize" control
   

3. Enable screen reader

4. Click the "Customize" control to open the dialog.

5. Screen reader reads through the list of controls and their current state

6. Navigate to the "Wrap long lines" checkbox and uncheck
   6.a. The labeling for the "line Wrapping" control is confusing and could be better worded
   Screen reader reads: "Line wrapping wrap long lines line wrapping wrap long lines check box checked"
   There are 2 label tags for the checkbox:
   Line Wrapping
   Wrap long lines
   Recommend eliminating the "Line Wrapping" label as supurflous.

7. Uncheck the checkbox - Screen reader does NOT indicate the field has changed until the user navigates away then back to the checkbox
   (see attached zipped video)
   Checkbox no announcement NVDA.zip

Meta Issue
Accessibility Audit for Kibana 7.0

Kibana Version:
7.2

OS:
Tested on Windows 7. But issue exists in all OS's

Browser:
Tested in Chrome. But issue exists in all Browsers

Screen reader: [if relevant]
NVDA

Relevant WCAG Criteria: WCAG Criterion
Navigable
Guideline 2.4: Provide ways to help users navigate, find content, and determine where they are.
1.3.1 Info and Relationships - Level A
Information, structure, and relationships conveyed through presentation can be programmatically determined or are available in text.

Relevant ARIA spec: WAI-ARIA Authoring Practices 1.1
N/A

[elasticmachine]

Pinging @elastic/infra-logs-ui

[Zacqary]

Screen reader reads: "Line wrapping wrap long lines line wrapping wrap long lines check box checked"

VoiceOver is describing the checkbox correctly:

NVDA is for some reason reading these things twice, similarly to how it reads both the title and aria-label attributes if an element has both.

This particular instance is tied to how EUI implements label and it's not something we can change from the Kibana codebase. Need @elastic/eui-design guidance on what to do here.

[Zacqary]

There are 2 label tags for the checkbox:
Line Wrapping
Wrap long lines
Recommend eliminating the "Line Wrapping" label as supurflous.

@elastic/eui-design <EuiFormRow>s seem to be applying the for attribute on their rendered <label> elements to whatever <input> control is rendered as a child. Maybe this isn't best practice? Or we could add an option to disable it in cases like this?

[Zacqary]

On the twice-reading of labels, this appears to be an open NVDA issue: nvaccess/nvda#7948

[jasonrhodes]

I dug into this a bit with @myasonik and @barlowm and from what we can tell, there isn't a reason this should be misbehaving in NVDA. They are going to look into it and also wait until the <EuiSwitch> is re-implemented (that may be happening soon) before re-testing this, and they said not to let this be a blocker, so I think we should close this and move on.

Thanks for spurring this conversation, @Zacqary!