Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Data frame transform JSON tab wrongly implies it is edit-able #41832

Closed
sophiec20 opened this issue Jul 23, 2019 · 2 comments · Fixed by #108310
Closed

[ML] Data frame transform JSON tab wrongly implies it is edit-able #41832

sophiec20 opened this issue Jul 23, 2019 · 2 comments · Fixed by #108310
Assignees
@alvarezmelissa87
Labels
bug Fixes for quality problems that affect the customer experience cosmetic Feature:Transforms ML transforms :ml v7.15.0

Comments

@sophiec20
Copy link
Contributor

Found in 7.3.0 { "build" : { "hash" : "46d4559", "date" : "2019-07-18T12:15:03.400569Z" },

  1. Open data frame transform list containing a transform
  2. Expand a row and select JSON tab
  3. Put cursor in JSON
  4. Hit esc

A message is displayed implying that you can edit the JSON. You cannot. This message should not be displayed.

image

Chrome, macOS Mojave
@sophiec20 sophiec20 added bug Fixes for quality problems that affect the customer experience :ml cosmetic Feature:Transforms ML transforms labels Jul 23, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui

@walterra walterra self-assigned this Jul 30, 2019
@walterra walterra mentioned this issue Aug 7, 2019
Merged
5 tasks
@walterra
Copy link
Contributor

walterra commented Aug 7, 2019

Looks like this is an issue with EUI itself, I could reproduce the same behaviour with the read-only version on the EUI examples page here: https://elastic.github.io/eui/#/forms/code-editor

Will file an issue in the EUI repo.

@walterra walterra mentioned this issue Aug 8, 2019
Closed
@walterra walterra removed the v7.4.0 label Aug 22, 2019
@walterra walterra removed their assignment Jan 29, 2020
@peteharverson peteharverson mentioned this issue Aug 12, 2021
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alvarezmelissa87 alvarezmelissa87

Labels
bug Fixes for quality problems that affect the customer experience cosmetic Feature:Transforms ML transforms :ml v7.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ML] Transforms: replace deprecated EuiCodeEditor alvarezmelissa87/kibana
5 participants
@walterra @sophiec20 @alvarezmelissa87 @peteharverson @elasticmachine