Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Banners to OverlayService #41986

Closed
joshdover opened this issue Jul 25, 2019 · 1 comment · Fixed by #43610
Closed

Add Banners to OverlayService #41986

joshdover opened this issue Jul 25, 2019 · 1 comment · Fixed by #43610
Assignees
@joshdover
Labels
Feature:New Platform Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@joshdover
Copy link
Contributor

Add the "banners" UI type to the OverlayService.

This is currently only used by the telemetry opt-in banner. In order for this banner to show in NP UI apps, we will need to move this API to the New Platform.
@joshdover joshdover added Feature:New Platform Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc labels Jul 25, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform

@joshdover joshdover mentioned this issue Aug 7, 2019
Merged
5 tasks
@joshdover joshdover self-assigned this Aug 20, 2019
@joshdover joshdover mentioned this issue Aug 20, 2019
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joshdover joshdover

Labels
Feature:New Platform Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move ui/notify banners to New Platform joshdover/kibana
2 participants
@joshdover @elasticmachine