Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow loading a new saved query when one is already loaded and in a dirty state #43887

Closed
TinaHeiligers opened this issue Aug 23, 2019 · 2 comments
Closed

Allow loading a new saved query when one is already loaded and in a dirty state #43887

TinaHeiligers opened this issue Aug 23, 2019 · 2 comments
Assignees
@TinaHeiligers
Labels
enhancement New value added to drive a business result Feature:Filters Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@TinaHeiligers
Copy link
Contributor

TinaHeiligers commented Aug 23, 2019 •
edited
Loading

Automatically disregard changes to a saved query when it's loaded and in a dirty state.

Steps to reproduce:

  1. Load a saved query.
  2. Make a change to the saved query.
  3. Try to reload the same saved query.
  4. Observe that we still have the save query in its dirty state loaded.
    dirty_saved_query_must_be_cleared

Enhancement
The changes to the saved query are disregarded when it is reloaded without clearing it first.

Considerations
A visual warning that current changes will be lost might be needed. Automatically disregarding intentional changes might not be desirable. What is needed is a way of undoing changes without explicitly needing to clear the query first.
@TinaHeiligers TinaHeiligers added Feature:Filters enhancement New value added to drive a business result Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Aug 23, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app

@TinaHeiligers TinaHeiligers self-assigned this Aug 23, 2019
@TinaHeiligers TinaHeiligers mentioned this issue Aug 23, 2019
Merged
1 task
@TinaHeiligers
Copy link
Contributor Author

This issue is addressed in PR 43927

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TinaHeiligers TinaHeiligers

Labels
enhancement New value added to drive a business result Feature:Filters Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TinaHeiligers @elasticmachine