Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR] Replace batched snapshot ES requests with single request #44817

Closed
jen-huang opened this issue Sep 4, 2019 · 1 comment · Fixed by #103331
Closed

[SR] Replace batched snapshot ES requests with single request #44817

jen-huang opened this issue Sep 4, 2019 · 1 comment · Fixed by #103331
Assignees
Labels
chore Feature:Snapshot and Restore Elasticsearch snapshots and repositories UI Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more

Comments

@jen-huang
Copy link
Contributor

In master (v8.0.0), the /api/snapshot_restore/snapshots endpoint currently still uses multiple ES requests to retrieve information about all snapshots: LOC

This is because due to previous ES API limitations, there was no way to retrieve information about all snapshots, from all repositories. The current logic first retrieves all repositories, then retrieves all snapshots from each repository.

With new changes in ES, GET /_snapshot/_all/_all to retrieve all snapshots from all repositories is now available. For performance, we should update this endpoint handler logic to use this new ES API instead.

Note: this change should be made against master only, as the ES changes are only available for 8.0.0.

@jen-huang jen-huang added chore Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more Feature:Snapshot and Restore Elasticsearch snapshots and repositories UI labels Sep 4, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Feature:Snapshot and Restore Elasticsearch snapshots and repositories UI Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants