Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new-platform] Prevent plugins lifecycle methods from blocking kibana startup #45417

Closed
rudolf opened this issue Sep 11, 2019 · 1 comment · Fixed by #45796
Closed

[new-platform] Prevent plugins lifecycle methods from blocking kibana startup #45417

rudolf opened this issue Sep 11, 2019 · 1 comment · Fixed by #45796
Assignees
Labels
discuss Feature:New Platform Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@rudolf
Copy link
Contributor

rudolf commented Sep 11, 2019

We should make it impossible for a single plugin lifecycle function to block all of kibana from starting up. For 7.5 we want consensus on the design (RFC) so that we understand the implementation risks and the migration effort for plugins who have already moved over to the NP or shims to adapt to the changes this feature might introduce.

Background:

Plugin lifecycle functions are async (promise-returning) functions. Core runs these functions in series and waits for each plugin's lifecycle function to resolve before calling the next. This allows plugins to depend on the API's returned from other plugins.

@rudolf rudolf added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Feature:New Platform labels Sep 11, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss Feature:New Platform Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants