-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add back window.onerror handler #45531
Labels
Feature:New Platform
stale
Used to mark issues that were closed for being stale
Team:Core
Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Comments
joshdover
added
Team:Core
Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Feature:New Platform
labels
Sep 12, 2019
Pinging @elastic/kibana-platform |
7 tasks
Timebox 1 hour investigation, triage next week |
We have two things now triggering window.onerror:
Both of these are fixable, but probably need to happen in EUI. I looked more into the behavior of
Options going forward:
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature:New Platform
stale
Used to mark issues that were closed for being stale
Team:Core
Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
In #41663, the global
window.onerror
error handler was not being imported / registered, so we've been allowing some silent errors for a few weeks now.Unfortunately, adding it back is causing Kibana to crash due to #22913. Once that issue is resolved, we should add this error handler back, directly in the New Platform's FatalErrorService.
The text was updated successfully, but these errors were encountered: