Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webpack Watchers #4682

Closed
spalger opened this issue Aug 17, 2015 · 4 comments
Closed

Webpack Watchers #4682

spalger opened this issue Aug 17, 2015 · 4 comments
Assignees
Labels
bug Fixes for quality problems that affect the customer experience dev Feature:Plugins

Comments

@spalger
Copy link
Contributor

spalger commented Aug 17, 2015

It seems that if you make changes to multiple files, and then refresh the page, it is possible that only the first file will be included in the build.

@spalger spalger added bug Fixes for quality problems that affect the customer experience v4.2.0 labels Aug 17, 2015
@spalger spalger self-assigned this Aug 17, 2015
@rashidkpc rashidkpc added the dev label Aug 18, 2015
@rashidkpc rashidkpc removed the v4.2.0 label Sep 11, 2015
@trevan
Copy link
Contributor

trevan commented Sep 14, 2015

To add my comment from the linked issue, sometimes, it doesn't even see the change in a single file.

@trevan
Copy link
Contributor

trevan commented Sep 28, 2015

I tracked down my issue to the watchpack module and created a pull request there: webpack/watchpack#17

@trevan
Copy link
Contributor

trevan commented Sep 28, 2015

If I make webpack use the old watcher, I also don't have my issue. I don't know what other issues it might cause though.

To go back to the old watcher, just add "new webpack.OldWatchingPlugin()" to the plugins array in src/optimize/BaseOptimizer.js

@spalger
Copy link
Contributor Author

spalger commented Mar 30, 2016

As far as I can tell this was fixed in #6395. Beyond the the upgrade to webpack2 (once it's out and tested) will mean we can start using the feature they have which supports this usage pattern.

@spalger spalger closed this as completed Mar 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience dev Feature:Plugins
Projects
None yet
Development

No branches or pull requests

4 participants